pre-release of extended Poll component available! - Page 2

akuate · 23.06.2004, 10:44

The new release is much better than the old one. Great work!!

I know that this release is to facilitate the mambo users, but here are some of the issues I found with the release. None of the issue is really big one but should help this great product to evolve into a mature one.

1. When you start adding options, the '+' sign with the question should be '-' as the option list is open
2. Mutliple voting checkbox is not behaving as it should, the checked box is gone once you do it. Same for other check box options too. The check is not appearing on admin UI though it is there in the database.
3. If the results are displayed on the main window, the poll is not shown on the screen (happens if we have only one poll published)
4. If we use "Initially hide options:" then we get javascript error alert on the site page once we choose the poll
5. The results if shown on the main window, then the first vote date and last vote date is coming arbit (sometimes the value is null)
6. The results if shown on the main window, then only the last poll os shown in polls position the previous poll(s) is not shown

Please let me know if any of the error description is not clear, I tried to be comprehensive.

I definitely feel this will be helpful for all the users. But want to appreciate the great module component that is extended poll. Great work!!

- akuate

akuate · 02.07.2004, 15:14

Ok, here it is, I don't know the solution for all of the issues mentioned here but here are some solutions:

Quote:

Originally Posted by akuate

2. Mutliple voting checkbox is not behaving as it should, the checked box is gone once you do it. Same for other check box options too. The check is not appearing on admin UI though it is there in the database.

Now this problem id due to incorrect slashes in the code. Look at the backslash used in the end of lines in original code:

PHP Code:

 
<input type="checkbox" class="checkbox" name="mypoll[multivote]" value="1" <?php if ($mypoll[multivote] == 1) echo checked ?>\>

You have to replace all of these slashes like this to the forward slash like this:

PHP Code:

 
<input type="checkbox" class="checkbox" name="mypoll[multivote]" value="1" <?php if ($mypoll[multivote] == 1) echo checked ?>/>

You are done.

Now for the second one:

Quote:

Originally Posted by akuate

5. The results if shown on the main window, then the first vote date and last vote date is coming arbit (sometimes the value is null)

For this you have to modify some lines of code in pollxt.php (Lines 165 to around 185 or so) as

PHP Code:

          foreach ($questions as $question) {

         $database->setQuery("SELECT * FROM #__pollsxt_options WHERE quid = '$question->id' ORDER BY id");

         $options = $database->loadObjectList();

           foreach ($options as $o) {

                         $database->setQuery("SELECT * FROM #__pollxt_data WHERE optid = '$o->id'");

                         $data = $database->loadObjectList();

 
                         $votes[$j][$i]["text"] = $o->qoption;

                         $votes[$j][$i]["hits"] = count($data);

                         $i++;

                        }

                        $j++; $i=0;

                     }

                    /** added by akuate**/

                    $database->setQuery("SELECT MAX(t1.datu) AS maxdate, MIN(t1.datu) AS mindate FROM #__pollxt_data as t1, #__pollsxt_options as t2, #__pollsxt_questions as t3, #__pollsxt as t4 where t4.id='$poll->id' AND t1.optid = t2.id AND t2.quid = t3.id AND t3.pollid = t4.id;");

                    $dates = $database->loadObjectList();

                    $first_vote = mosFormatDate( $dates[0]->mindate, _DATE_FORMAT_LC2 );

                    $last_vote = mosFormatDate( $dates[0]->maxdate, _DATE_FORMAT_LC2 );

 
 
        echo $database->getErrorMsg();

   if (!$my->id) $logonQuery = "AND logon=0";

   else $logonQuery = "";

Let me know if it helps!!
AKUATE

omerten · 21.07.2004, 04:45

Hola akuate,

first: sorry for my late response, was very busy and on holiday etc...
thanks for your detailed information, but I have several questions:
1.) I can not reproduce that... Do you have a javascript error or something like that?
2.) Thanks for the solution... will be included in .84
3.) I can not reproduce that... Do you have an example, where I can see it?
4.) will be solved with .84
5.) Your solution looks good, but I could not find any problems with my old solution... maybe I'll take yours ;-)
6.) I don't know if I understand the problem correctly... In the results always only one poll should be shown, the others can be selected via select-box.

Thanks again,

regards,

Oli

omerten · 25.07.2004, 08:09

Hola,

some additions, versions .85 (will be released tonight) will have your solution for 5.) (mine was in fact buggy) and some minor bugfixes in result display... probably 6. is solved with that?

Thanks for your hints,

regards,

Oli

akuate · 26.07.2004, 16:27

Hi,

I just integrated v0.85 to the earlier release. I must say that you have provided a much better version this time. Congratulations!! The copy question, image size and link features are great.

I have a few feedbacks though!
1. As in the current release only one parameter out of image height or width can be specified. It would be really great if the user can specify both height and width. Adds a lot of value.

2. Stripslashes inclusions have been great but it has been missed out at one crucial part. The place where we show results. The change has to be done in pollxt.html.php (somehwhere near line 193)

PHP Code:

<?php echo $text; ?>

needs to be changed to:

PHP Code:

<?php echo stripslashes($text); ?>

3. Currently the polls results are shown in random order, it would be great if the results can be shown in descending order (based on number of hits). I'm using this code in pollxt.php (around line 183)

PHP Code:

  $database->setQuery("SELECT a.*, COUNT(b.optid) as hits FROM #__pollsxt_options a, #__pollxt_data b WHERE a.quid = '$question->id' and a.id=b.optid group by a.qoption order by hits DESC");

But I guess the extended polls is stable now and you can release version 1.0. Best of luck!!

Regards,
Akuate

akuate · 26.07.2004, 21:59

Sorry for point three the query should be:

Code:

SELECT a.*, COUNT(b.optid) as hits FROM #__pollsxt_options a left outer join #__pollxt_data b on a.id=b.optid WHERE a.quid = '$question->id' group by a.qoption order by hits DESC, a.id ASC

omerten · 27.07.2004, 03:35

Hi akuate,

thanks again for your recommendations and testing. But this time you were a little late ;-) At least the slashes are already stripped in version 0.86. I'm thinking about re-writing parts of the results display sooner or later, I guess your recommendation will be part of that.
Regarding images: I think definition of width or height is enough (otherwise you'd mess up the proportions of the image), but if you have some good reasons, I could be easily convinced...

Thanks,

Oli

akuate · 29.07.2004, 20:28

Seems like you are releasing new version every day! That's good for the commnunity...

concerning version 0.87, what is the concept of obligatory question. Can you please explain the significance?

Regards,
Akuate